feat: add helm chart for image factory #316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanduur
force-pushed
the
chart
branch
3 times, most recently
from
1c9ad24 to
4332cb8
Compare
shanduur
changed the title
shanduur
force-pushed
the
chart
branch
7 times, most recently
from
dce1c41 to
7e8cf28
Compare
TimJones
reviewed
Sep 30, 2025
| {{- $_ := set .Values.ingress.pxe.annotations "kubernetes.io/ingress.class" .Values.ingress.pxe.className}} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}} |
There was a problem hiding this comment.
Should we support such old versions of k8s?
There was a problem hiding this comment.
I'm always using this template for Ingresses, no need to support it, I just didn't removed that part of code. 😄
Added helm chart and unit tests for templates. Signed-off-by: Mateusz Urbanek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the tests manually:
Unit tests:
helm unittest ./deploy/helm/image-factory1helm unittest ./deploy/helm/registry1Smoke E2E:
chainsaw test2Signed-off-by: Mateusz Urbanek [email protected]
Footnotes
https://github.com/helm-unittest/helm-unittest ↩ ↩2
https://kyverno.github.io/chainsaw/latest/ ↩