refactor: drop extra input finalizers #1517
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
refactor/drop-extra-input-finalizers
branch
from
2db768d to
bf57ade
Compare
smira
force-pushed
the
refactor/drop-extra-input-finalizers
branch
3 times, most recently
from
0370690 to
1a7b028
Compare
Unix4ever
reviewed
Sep 25, 2025
| return err | ||
| } | ||
|
|
||
| func dropExtraInputFinalizers(ctx context.Context, st state.State, logger *zap.Logger, _ migrationContext) error { |
There was a problem hiding this comment.
I think we need some test for the migration.
smira
force-pushed
the
refactor/drop-extra-input-finalizers
branch
from
1a7b028 to
6a8ae81
Compare
Simplify controllers, add migrations to clear finalizers which are no longer needed. See cosi-project/runtime#633 Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
refactor/drop-extra-input-finalizers
branch
from
6a8ae81 to
9cbc446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify controllers, add migrations to clear finalizers which are no longer needed.
See cosi-project/runtime#633