docs: use ConfigMap for Cilium job based installation example #9039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing the command args to cilium CLI results in are error where list elements are interpreted as a single argument, producing an error. Attempts to split them out lead to issue parsing the capabilities list. Use a ConfigMap avoids these issues. Signed-off-by: Matt Willsher <[email protected]>
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What? (description)
Passing the command args to cilium CLI results in an error where the list elements are interpreted as a single argument, producing an error. Attempts to split them out lead to issues parsing the capabilities list.
Using a ConfigMap avoids these issues.
#9034 changes the same example.
Why? (reasoning)
I don't understand why the example in the docs didn't work for me, but this new approach worked both when applied directly and when run via the talos Terraform provider.
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)