-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI adjustments for sky #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -12,7 +11,6 @@ | |||
:is-wallet-loading="isWalletLoading" | |||
:has-accepted-terms="hasAcceptedTerms" | |||
:staging-banner-url="stagingBannerURL" | |||
:production-banner-url="productionBannerURL" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this back, as this is out of scope of this update. This banner is being used to differentiate staging from production, see it in action here: https://main.auctions-ui.k8s.sidestream.tech
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the variable back, but not sure StagingBanner
uses productionBannerURL
.
I removed it with banner that refers to the electron app
which was outlined in the issue. Do you think we need to bring this one back as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, maybe it's just a confusing name of the variable (as well as confusing use of it). This can be tested by providing PRODUCTION_BANNER_URL
env variable to the frontend
This reverts commit 3cebcbe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make UI adjustments to the UI to align with the new brand.
(color theme, logo)
Checklist:
#
)