Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Requests #3

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Generate Requests #3

wants to merge 43 commits into from

Conversation

CrypticSwarm
Copy link

  • Core Protocol Request/Reply handling.
  • Converted many of the tests

Most things work.

PolyText8 doesn't work. It seems the XML and the spec differ and I am not sure why.
Render Extension is probably broken if it uses the old api.

@CrypticSwarm
adding xml/json spec as sub-project
6657b88
@CrypticSwarm
moving/modifing pack value mask helper to seperate file.
49ae09c
@CrypticSwarm
quick mockup of generating x requests.
d8b3b8a
@CrypticSwarm
updates info for valuemasks.
e7a4e89 
Still need to calculate the length.
Still need to handle normal list types.
@CrypticSwarm
fix a few errors and calulate size of request.
65c74b1
@CrypticSwarm
convert a test to use the new request format.
804be9a
@CrypticSwarm
update request generator to give simple responses.
7d3b211
@CrypticSwarm
show QueryTree response.
ab3ad6e
@CrypticSwarm
added char list packing / unpacking.
8597bd8
@CrypticSwarm
changed atoms test.
ff58ea5
@CrypticSwarm
make hidden props non enumerable.
bd20afb
@CrypticSwarm
rearranging and properly indenting generated code.
db524a7
@CrypticSwarm
move some util functions out of the auto generated file.
5d8ae42
@CrypticSwarm
makes the offset added to result of buf.unpack array non enumerable
ebbbbcc
@CrypticSwarm
update protocols sub project
e6da58a
@CrypticSwarm
added a pack/unpack struct template file
cd28911
@CrypticSwarm
fleshed out pack and unpack sub templates
545ca43
@CrypticSwarm
generated the requests and structs with new templates.
cc78999 
result: should now be able to handle requests with nested structs.
@CrypticSwarm
added a ListHosts test/example
37ff1d0 
mainly because the result has a nested struct and I wanted to make sure
that it was working.
@CrypticSwarm
requests requiring lists the fields are now added appropriately.
d529073
@CrypticSwarm
added a rectangles test.
bd97623 
pretty messed up.
@CrypticSwarm
removing unneeded rectangle_len in test/rect
fae0e8b
@CrypticSwarm
fixes adding length specifier when shouldn't.
4f1a8a7
@CrypticSwarm
allows lists of items to be either a single or array of items.
225e124
@CrypticSwarm
updated alloccolor test
6d5b414
@CrypticSwarm
fixes problem with void data incorrectly packed/unpacked.
5478a6a
@CrypticSwarm
brings test/changeproperty to the new api
edc1fc6
@CrypticSwarm
brings test/creategc to new api
d7830e3
@CrypticSwarm
brings test/createwindow to new api
eaaa2f9
@CrypticSwarm
brings test/genstdatoms to new api
3b70fcf
@CrypticSwarm
cleanup delete unused c-test files
8cd04d3
@CrypticSwarm
fixes issues that GetKeyboardMapping had
00fc7c3 
 - sometimes end of request needs to be padded to 4 byte align
 - some requests reference the request Length
   (may have issues with a few others that do operations on req Length)
 - makes sure variable is set to empty array even when no fields.
@CrypticSwarm
brings test/getkeyboardmapping to new api
9a84a4d
@CrypticSwarm
fixes reply lists with operators and body length usage.
6fa0d51 
 - sends body length to all reply handler functions.
 - handle operators and nested operators for list length.
@CrypticSwarm
brings test/getprop to new api
08b6d12
@CrypticSwarm
fixes prop not being added for unpacking toa struct in some situations
a8432ff
@CrypticSwarm
makes Buffer.offset writeable.
b007587
@CrypticSwarm
brings test/testext to new api
437f9b1
@CrypticSwarm
brings test/polyfillrect to new api
5edff65 
why draw multiple rects ontop of eachother?
Solution turn one of them red.
@CrypticSwarm
brings test/polyline to new api
abaade7
@CrypticSwarm
brings test/polyline to new api
005095d
@CrypticSwarm
brings test/query_ext to new api
c505296
@CrypticSwarm
brings test/query_pointer to new api
f5290b6
@CrypticSwarm
Copy link
Author

Continued from: (#5)

Leaving the attributes names as is.
Comment: If you leave them the same can also generate the docs.
Response: Can generate the docs even if the names are changed. That part doesn't matter as long as we have consistent names. Consistent API's I think are nice :) Also most of the XCB uses underscores instead of camel case. This uses camel case for the most part already.

Comment: don't use value_mask either value or merge mask into parent obj.
Response: agreed value_mask isn't the most appropriate. Either one is good.
Note: If merge attributes with the rest of the request params. Need to change code to not throw errors if a wrong value_mask key is passed.
Question: Are there any requests that a Key from the value mask will collide with any of the other request params in any of the extensions? This is one thing to think about.

@CrypticSwarm
Copy link
Author

Thoughts?

@sidorares sidorares mentioned this pull request Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CrypticSwarm