-
Notifications
You must be signed in to change notification settings - Fork 111
fix(core/category-filter): fixed automatic focus in filter when filterState is set programmatically #2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(core/category-filter): fixed automatic focus in filter when filterState is set programmatically #2080
Conversation
🦋 Changeset detectedLatest commit: dbd9bb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only work if the input is already focused. If the the user clicks the dropdown or navigates it via keyboard this will the focus will not work anymore.
Maybe we can extract the focus logic from addToken
and add it to the respective event handlers only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. I have updated the code now
|
💡 What is the current behavior?
GitHub Issue Number: #
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support