fix: always call <ngx-datatable-row-detail [rowHeight]="function"> with correct index
#489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
force-pushed
the
fix/body/always-call-details-row-height-with-correct-index
branch
from
eb40aa5 to
c14135b
Compare
9 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with row detail height calculation in external paging mode by correcting the indexOffset parameter passed to the row height cache. Previously, the index offset was incorrectly using indexes().first, which is always 0 in external paging mode, causing incorrect indices to be passed to detailRowHeight callbacks on pages beyond the first.
- Changed
indexOffsetcalculation incomputeRowHeightsCache()to properly account for external paging - Added comprehensive tests for row detail directive behavior with row expansion/collapse
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/ngx-datatable/src/lib/components/body/body.component.ts | Fixed indexOffset calculation to use offset() * pageSize() for external paging instead of indexes().first |
| projects/ngx-datatable/src/lib/components/row-detail/row-detail.spec.ts | Added test suite for DatatableRowDetailDirective with tests for row expansion/collapse and index verification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…with correct index Previously, when using `<ngx-datatable-row-detail [rowHeight]="function">`, the function was called sporadically with a wrong index. This is due to a bug in the body-component, where the rendered offset-index was passed to the cache. But the cache is operating on all rows, not the rendered ones. So instead, we need to pass only the offset, if external paging is enabled.
fh1ch
force-pushed
the
fix/body/always-call-details-row-height-with-correct-index
branch
from
c14135b to
eecbadc
Compare
fh1ch
deleted the
fix/body/always-call-details-row-height-with-correct-index
branch
|
🎉 This PR is included in version 24.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
When using
<ngx-datatable-row-detail [rowHeight]="function">, the function was called sporadically with a wrong index. This is due to a bug in the body-component, where the rendered offset-index was passed to the cache.What is the new behavior?
The cache is operating on all rows, not the rendered ones. So instead of rendered-offset, we need to pass only the
offset, if external paging is enabled.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
I don't think, the index is actually used to compute the detailsHeight. But at least it is correct now.
The main motivation here is actually to avoid circular references so I can make more things computed.