Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace markdown-link-check with lychee #265

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

michaeladler
Copy link
Member

Description

Replace markdown-link-check with lychee to reduce maintenance burden, as the current version has been broken for 2 months [1].

[1] tcort/markdown-link-check#369

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

Replace markdown-link-check with lychee to reduce maintenance burden, as
the current version has been broken for 2 months [1].

[1] tcort/markdown-link-check#369

Signed-off-by: Michael Adler <[email protected]>
@michaeladler michaeladler requested a review from stormc as a code owner January 7, 2025 09:47
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (aee20ca) to head (dbaabc3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          97       97           
  Lines        4885     4885           
=======================================
  Hits         4058     4058           
  Misses        599      599           
  Partials      228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaeladler michaeladler merged commit 36459f2 into siemens:main Jan 7, 2025
14 checks passed
@michaeladler michaeladler deleted the ci/linkcheck branch January 7, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants