Use Arc dyn BlobStore insteadl of impl #1491
Conversation
rust/rsc/src/rsc/main.rs
Outdated
| @@ -61,7 +61,9 @@ struct ServerOptions { | |||
| fn create_router(conn: Arc<DatabaseConnection>, config: Arc<config::RSCConfig>) -> Router { | |||
| // If we can't create a store, just exit. The config is wrong and must be rectified. | |||
| let root = config.local_store.clone().unwrap(); | |||
| let store = blob::LocalBlobStore { root }; | |||
| //let store = blob::LocalBlobStore { root }; | |||
There was a problem hiding this comment.
commented code should be removed
copies don't share state and thus a) can mutate when shared across threads and b) can't update when they need to. The point is NOT to avoid the copy, this is more expensive than just doing a copy, the point is to have a single source of truth. |
|
Also the core core core issue that you seem to keep missing is that you CANNOT dynmaically dispatch based on the config across an |
This changes the BlobStore trait to be object safe while maintaining most of the generality of the previous implementation.