rsc: Basic attempt at uuid as id #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ impl MigrationTrait for Migration { | |||
| .table(LocalBlobStore::Table) | |||
| .col( | |||
| ColumnDef::new(LocalBlobStore::Id) | |||
| .integer() | |||
| .uuid() | |||
| .not_null() | |||
| .primary_key(), | |||
There was a problem hiding this comment.
Does this need the default call pointing to gen_random_uuid?
There was a problem hiding this comment.
Nice call out, in this case no but only for a sneaky reason.
LocalBlobStore is a "dependent table" of the BlobStore (kind of like a subclass) and its ID is a foreign key to BlobStore's ID. That means the ID must always be manually set to and already existing BlobStore ID
Yeah lol, changing that for wake would be a very large project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is updates all models/tables to use UUIDs. This is important for concurrently/db destruction/multi-client as we can't guarentee that two different clients won't ever get the same integer id representing 2 different jobs. With this change, even if bad db stuff happens we ensure running clients don't confuse jobs as every new job will always get a unique id regardless of the previous state of the db.
It properly generates new UUIDs by default but it takes a hard dependence on Postgres. To land this PR we would have to drop sqlite3 support which has now been completed.
This change rewrites history but we just did that in the last PR so might as well get them all in at once
The standalone tests have been updated and now properly use a sandboxed postgres