Do not use cache after the failure cap is reached #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinschmidt
approved these changes
Dec 18, 2023
| FindJobResponse Cache::read(const FindJobRequest &find_request) { | ||
| if (misses_from_failure > timeout_config.max_misses_from_failure) { |
There was a problem hiding this comment.
Are the two new guards supposed to also include miss_on_failure? I guess if miss_on_failure is not set we wouldn't expect misses_from_failure to be non-zero and therefore these guards should never trigger, so its just a style question not a functionality quesiton.
There was a problem hiding this comment.
Yeah its never going to be reached. We only use miss_on_failure to determine if the miss is a failure or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just makes it so that no attempt is made whatsoever after the failure cap is reached, this includes add.
As a toss in I also fixed add not using the config.