Return success: true when deleting your team #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
May 31, 2019 22:45
Yes this is _slightly_ insecure, because this allows attackers to enumerate usernames, however noone using this platform cares that much that their username remaining hidden. Additionally, an attacker could just create an account and list users anyway.
…wn team's stats This is so that the frontend doesn't have to do a lookup to get the user's team *NAME* before it can get the team's stats. The website is currently only intended to show the current user's team's stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the server responds with "success: false" when you successfully delete a team, this is incorrect.