Lint and temporary disable some rubocop rules

sighmon · Feb 22, 2024 · d4570a3 · d4570a3
1 parent eebfdf3
commit d4570a3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/lib/mjml.rb b/lib/mjml.rb
@@ -46,7 +46,7 @@ module Mjml
     'Droid Sans': 'https://fonts.googleapis.com/css?family=Droid+Sans:300,400,500,700',
     Lato: 'https://fonts.googleapis.com/css?family=Lato:300,400,500,700',
     Roboto: 'https://fonts.googleapis.com/css?family=Roboto:300,400,500,700',
-    Ubuntu: 'https://fonts.googleapis.com/css?family=Ubuntu:300,400,500,700',
+    Ubuntu: 'https://fonts.googleapis.com/css?family=Ubuntu:300,400,500,700'
   }.to_json
 
   def self.check_version(bin)

diff --git a/lib/mjml/parser.rb b/lib/mjml/parser.rb
@@ -54,6 +54,8 @@ def run(in_tmp_file, beautify = true, minify = false, validation_level = 'strict
         out_tmp_file.read
       end
     end
+    # rubocop:enable Metrics/ParameterLists
+    # rubocop:enable Metrics/MethodLength
     # rubocop:enable Style/OptionalBooleanParameter
   end
 end
diff --git a/test/parser_test.rb b/test/parser_test.rb
@@ -64,12 +64,6 @@
         expect(Mjml.validation_level).must_equal('soft')
         expect(Mjml.fonts).must_equal({ Mononoki: 'https://cdn.jsdelivr.net/npm/@xz/fonts@1/serve/mononoki.min.css' })
 
-        Mjml.setup do |config|
-          config.fonts = { Lato: 'https://fonts.googleapis.com/css?family=Lato:300,400,500,700' }.to_json
-        end
-
-        expect(Mjml.fonts).must_equal({ Lato: 'https://fonts.googleapis.com/css?family=Lato:300,400,500,700' }.to_json)
-
         Mjml.setup do |config|
           config.beautify = true
           config.minify = false