fix(setup): Use resolve() before invoking as_uri()#700
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
- Coverage 95.08% 95.03% -0.05%
==========================================
Files 40 40
Lines 2358 2358
==========================================
- Hits 2242 2241 -1
- Misses 116 117 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sigma67
left a comment
There was a problem hiding this comment.
Not instead, in addition. Don't change the behavior of the print statement - with this change the link won't be clickable in terminal
Please also add a test
If a relative file path is provided, `as_uri()` throws a ValueError. Resolve the path to be absolute before converting to URI.
|
I'm inclined to say the test is that you run |
|
in my local installation i ended up just removing |
If a relative file path is provided, `as_uri()` throws a ValueError. Resolve the path to be absolute before converting to URI.
If no
--fileargument is provided to setup,as_uri()throws a ValueError when it tries to get the relative path to print to the console. Usingresolve()will work in both case (--fileprovided or not provided).Fixes #699