feat: adds layout #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdsrqbl
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Nice work!
ahmed_layout.mp4
Here are a few things I thought we could adjust:
- toggling the sidebar with a button and collapse by default on vertical screens
- a margin/empty element on the right side equal in width to the sidebar to balance the symmetry.
- some space between the sidebar item's icon and text
- the height of the translator component
mdsrqbl
reviewed
Sep 25, 2024
There was a problem hiding this comment.
I think the convention for jsx and variable names is camelCase instead of snake_case so lets ensure that everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.