Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WebWorker for MediaPipe Holistic - Fixes #24 #28

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

AmitMY
Copy link
Contributor

@AmitMY AmitMY commented Dec 16, 2021

Currently fails due to canvas being referenced in the holistic source code - issue google-ai-edge/mediapipe#2506

Fixes #24

# Conflicts:
#	src/app/modules/pix2pix/pix2pix.service.ts
# Conflicts:
#	angular.json
#	src/app/components/video/video.component.ts
#	src/app/core/helpers/image/transferable.ts
#	src/app/modules/animation/animation.service.ts
#	src/app/modules/detector/detector.service.ts
#	src/app/modules/pix2pix/pix2pix.service.ts
#	src/app/modules/pix2pix/pix2pix.worker.ts
#	src/app/modules/pose/pose.service.ts
#	src/app/modules/pose/pose.state.ts
#	src/app/modules/sign-writing/body.service.ts
#	src/app/modules/sign-writing/sign-writing.state.ts
#	src/app/modules/translate/translate.service.ts
#	src/app/pages/translate/translate.component.ts
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023

Visit the preview URL for this PR (updated for commit 56bfcd2):

https://translate-sign-mt--pr28-holistic-worker-nzqu5dt3.web.app

(expires Wed, 25 Jan 2023 14:44:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 739446cfe7a349700ebd347d2a39e3b90ba24425

Copy link
Contributor Author

@AmitMY AmitMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge looks good.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3949819452

  • 34 of 50 (68.0%) changed or added relevant lines in 10 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 51.849%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/components/video/video.component.ts 0 1 0.0%
src/app/modules/translate/translate.service.ts 0 1 0.0%
src/app/pages/translate/translate.component.ts 0 1 0.0%
src/app/modules/pose/pose.state.ts 6 8 75.0%
src/app/modules/sign-writing/body.service.ts 1 3 33.33%
src/app/modules/pose/pose.service.ts 16 25 64.0%
Files with Coverage Reduction New Missed Lines %
src/app/core/services/assets/assets.service.ts 2 39.89%
src/app/core/services/holistic.service.ts 10 35.29%
Totals Coverage Status
Change from base Build 3948860130: -0.09%
Covered Lines: 1054
Relevant Lines: 1940

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Worker for Mediapipe Holistic
2 participants