Restore high-cardinality Lettuce metrics for debugging

signalapp · Feb 9, 2024 · c5dc01e · c5dc01e
1 parent 587c385
commit c5dc01e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MetricsUtil.java b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MetricsUtil.java
@@ -76,15 +76,14 @@ public DistributionStatisticConfig configure(final Meter.Id id, final Distributi
             return defaultDistributionStatisticConfig.merge(config);
           }
         })
-        // Remove high-cardinality `command` and `remote` tags from Lettuce metrics and prepend "chat." to meter names
+        // Remove high-cardinality `command` tags from Lettuce metrics and prepend "chat." to meter names
         .meterFilter(new MeterFilter() {
           @Override
           public Meter.Id map(final Meter.Id id) {
             if (id.getName().startsWith("lettuce")) {
               return id.withName(PREFIX + "." + id.getName())
                   .replaceTags(id.getTags().stream()
                       .filter(tag -> !"command".equals(tag.getKey()))
-                      .filter(tag -> !"remote".equals(tag.getKey()))
                       .toList());
             }
 

diff --git a/service/src/test/java/org/whispersystems/textsecuregcm/metrics/MetricsUtilTest.java b/service/src/test/java/org/whispersystems/textsecuregcm/metrics/MetricsUtilTest.java
@@ -37,7 +37,6 @@ void lettuceTagRejection() {
     Meter meter = meters.get(0);
     assertThat(meter.getId().getName()).isEqualTo("chat.lettuce.command.completion.max");
     assertThat(meter.getId().getTag("command")).isNull();
-    assertThat(meter.getId().getTag("remote")).isNull();
     assertThat(meter.getId().getTag("allowed")).isNotNull();
   }
 }