Add timeouts to crawl chunk join()s

signalapp · Aug 31, 2023 · ecd6b01 · ecd6b01
1 parent a1e534a
commit ecd6b01
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/storage/AccountCleaner.java b/service/src/main/java/org/whispersystems/textsecuregcm/storage/AccountCleaner.java
@@ -61,7 +61,9 @@ protected void onCrawlChunk(Optional<UUID> fromUuid, List<Account> chunkAccounts
         .toList();
 
     try {
-      CompletableFuture.allOf(deletionFutures.toArray(new CompletableFuture[0])).join();
+      CompletableFuture.allOf(deletionFutures.toArray(new CompletableFuture[0]))
+          .orTimeout(10, TimeUnit.MINUTES)
+          .join();
     } catch (final Exception e) {
       log.debug("Failed to delete one or more accounts in chunk", e);
     }

diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/storage/PushFeedbackProcessor.java b/service/src/main/java/org/whispersystems/textsecuregcm/storage/PushFeedbackProcessor.java
@@ -112,7 +112,9 @@ protected void onCrawlChunk(Optional<UUID> fromUuid, List<Account> chunkAccounts
         .toList();
 
     try {
-      CompletableFuture.allOf(updateFutures.toArray(new CompletableFuture[0])).join();
+      CompletableFuture.allOf(updateFutures.toArray(new CompletableFuture[0]))
+          .orTimeout(10, TimeUnit.MINUTES)
+          .join();
     } catch (final Exception e) {
       log.debug("Failed to update one or more accounts in chunk", e);
     }