Skip to content

Conversation

@pellared
Copy link
Contributor

@pellared pellared commented Dec 8, 2025

Follows #362

So that we have a chance to double-check when stabilizing the feature.

If this is indeed stable then changes like #358 should not be allowed. If this is a bugfix then it should be at least mentioned in the changelog as a bugfix. However, I think it is questionable if this was a bug. Note that e.g. parentbased_traceidratio accepts 0 as a valid value (reference: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#general-sdk-configuration).

@pellared pellared marked this pull request as ready for review December 8, 2025 07:13
@pellared pellared requested review from a team as code owners December 8, 2025 07:13
@pellared
Copy link
Contributor Author

pellared commented Dec 9, 2025

@breedx-splk, @seemk , PTAL

@seemk
Copy link
Contributor

seemk commented Dec 9, 2025

I think #358 should be reverted, zero probability makes sense. 🤔 Approved it too hastily

@pellared
Copy link
Contributor Author

pellared commented Dec 9, 2025

I think #358 should be reverted, zero probability makes sense. 🤔 Approved it too hastily

@seemk, do I understand correctly that you just prefer to revert #358 and keep this section Stable (as you have not approved this PR 😉 )?

@Kielek
Copy link
Contributor

Kielek commented Dec 11, 2025

Closing in favor of #366

@Kielek Kielek closed this Dec 11, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2025
@pellared
Copy link
Contributor Author

pellared commented Dec 11, 2025

Closing in favor of #366

These are not exclusive PRs.

Note that both @seemk and @lachmatt have approved this PR.

I would like to have confirmation from @breedx-splk, @seemk, and @lachmatt that these env vars can be stabilized.
It is easier to do it via PRs. Then we also have a history in GitHub.

Moreover, these env vars are not even described in the changelog.

@pellared pellared reopened this Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants