Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate deprecated APIs/Methods #1157

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Conversation

tonzhan2
Copy link
Contributor

@tonzhan2 tonzhan2 commented Jan 22, 2025

Marking to-be-deprecated methods, APIs and, classes with deprecation annotations

@tonzhan2 tonzhan2 marked this pull request as ready for review January 24, 2025 22:41
@tonzhan2 tonzhan2 requested a review from a team as a code owner January 24, 2025 22:41
Copy link
Contributor

@surbhiia surbhiia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -126,7 +126,9 @@ static SplunkRum initialize(SplunkRumBuilder builder, Application application) {
*
* @param screenName Name of the new screen or null when exiting explicit UI navigation mode.
* @param spanType "Created", "Restarted", or "Resumed"
* @deprecated This method is deprecated and will be removed in a future release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users who encounter this might wonder what they can use instead. Can you provide a recommendation in the javadocs as to what other approach to take?

@tonzhan2 tonzhan2 merged commit 323a463 into main Jan 28, 2025
3 checks passed
@tonzhan2 tonzhan2 deleted the annotateDeprecatedAPIsAndMethods branch January 28, 2025 05:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants