Add custom tracking module #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenNeonoveNoci
approved these changes
Feb 7, 2025
Yeah, I considered this as well. As there wasn't any configuration to be supplied to this module at this point, so thought we'll wait on that for now until it's clearly known that we need it. |
tonzhan2
reviewed
Feb 8, 2025
| @@ -15,7 +15,7 @@ apply<ConfigAndroidLibrary>() | |||
| apply<ConfigPublish>() | |||
|
|
|||
| ext { | |||
| set(artifactIdProperty, "$artifactPrefix${commonPrefix}otel-${project.name}") | |||
There was a problem hiding this comment.
Maybe I missed the context here but how come we're removing the 'otel' part of this name?
There was a problem hiding this comment.
As mentioned in the what PR covers bullet points - The published library name was earlier - rum-common-otel-otel which was changed to rum-common-otel
tonzhan2
approved these changes
Feb 8, 2025
TomasChladekSL
approved these changes
Feb 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the following:
:agentmodule, for it to be available to customers using defaults directly.:common:otelto hold certain re-usable constantrum-common-otel-otelpublished library name torum-common-otel