-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new dimension to internal metrics to identify mode #1634
Conversation
While the end result of this PR should be usable for both myself and users, I recommend we consider a different implementation for this feature to ensure better support for previous, current, and future support Suggested Plan:
Current Labels Example for Different Modes:
Then you you can use the k8sattributes processor to read the component label on the pods and apply them to telemetry data (like the internal collector metrics)
This approach will enhance flexibility and ensure compatibility with future updates. Let me know your thoughts. |
Just to get this PR merged, we can go the simple route and just use the
|
FYi, these attrs are in-line with what we have in non-k8s configs and I think we should stick with these to reduce confusion for users with k8s/host mixed envs (PR for ref). But agree that we should add this to the k8s cluster receiver (we also document it as a different mode for k8s). The value should be |
It would be also good to update existing tests and add a check for this newly added attribute |
helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl
Outdated
Show resolved
Hide resolved
You'll also have to add a changlog entry since the templates were updated and this is an enhancement feature. |
Co-authored-by: jvoravong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit and then this PR LGTM!
I'm working on getting the tests to run |
This PR is low risk, let's not worrying about the extra functional tests that run on eks, gke, and aks for this PR. We should make sure they pass in the future though. |
Description:
To easily filter between agent and gateway deployments of the collector in dashboards a proposed new dimension
otelcol.service.mode
to be added to the internal metrics pipeline.Testing:
Deployed the chart to a cluster with the gateway enabled. Validated on the OOTB otel collector dashboard I can filter on
otelcol.service.mode
with both a value foragent
andgateway
Deployed the chart to a cluster with the gateway disabled. Validated on the OOTB otel collector dashboard I can filter on
otelcol.service.mode
with only a value foragent
This feature is already merged into the splunk otel-collector: signalfx/splunk-otel-collector#5701