Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to deploy Instrumentation resource when operator sub chart is disabled #1650

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

Option to deploy Instrumentation resource when operator sub chart is disabled #1650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ea42a0
Option to deploy Instrumentation resource when operator sub chart is …
icicimov Feb 8, 2025
e789b32
Option to deploy Instrumentation resource when operator sub chart is …
icicimov Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm-charts/splunk-otel-collector/templates/operator/instrumentation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.operator.enabled }}
{{- if or .Values.operator.enabled .Values.instrumentation.enabled }}
{{- include "splunk-otel-collector.operator.validation-rules" . -}}
apiVersion: opentelemetry.io/v1alpha1
kind: Instrumentation
Expand Down
4 changes: 4 additions & 0 deletions helm-charts/splunk-otel-collector/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1496,6 +1496,10 @@
"type": "object",
"additionalProperties": false,
"properties": {
"enabled": {
"description": "Flag to enable instrumentation when operator is deployed via external chart.",
"type": "boolean"
},
"endpoint": {
"type": "string",
"description": "Optional endpoint parameter for exporting data to a specific target."
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/splunk-otel-collector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,6 +1231,8 @@ operator:
# - Splunk Documentation: https://docs.splunk.com/observability/en/gdi/opentelemetry/automatic-discovery/k8s/k8s-backend.html#optional-configure-the-instrumentation
# - OpenTelemetry Documentation: https://github.com/open-telemetry/opentelemetry-operator/blob/main/docs/api.md#instrumentation
instrumentation:
# (optional) Deploy when the operator is disabled (in case when managed by external chart)
enabled: false
# Optional "endpoint" parameter for exporting data to a specific target.
# By default, the endpoint will be set to the agent if it's enabled. If the agent is not enabled, the endpoint
# will default to the gateway, given it is enabled. If neither the agent nor the gateway is enabled, the endpoint
Expand Down