Skip to content

[chore] rewrite python tests into golang and remove python tests #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pszkamruk-splunk
Copy link
Contributor

@pszkamruk-splunk pszkamruk-splunk commented Feb 10, 2025

Description: This PR contains changes related to removing the Python dependency from the project. Python was previously used for Splunk integration tests, which have now been rewritten in Golang.

Changes:

  1. Rewriting existing Python tests in Golang.
  2. Removing Python-related test files and unnecessary configuration files.
  3. Updating the pipeline to run Golang Splunk integration tests.
  4. Improving test verifications.
  5. Adding missing tests to fully test the pod annotations feature (the setup.yaml file contains configurations that were not fully tested).

Next steps:

  1. Integrate Golang Splunk integration tests with existing functional tests
  • use testcontainers-go to spin Splunk
  • setup environment via deployEnv function
  • integration with existing functional test matrix

PS. Current pipeline which runs minikube with different container runtimes for docker will be removed this will reduce the number of jobs to run. Also number of tested Splunk versions will be reduced to the latest one.

� Conflicts:
�	.github/workflows/functional_test.yaml
�	test/k8s_logging_tests/test_config_logging.py
@pszkamruk-splunk pszkamruk-splunk force-pushed the rewrite-python-tests-into-golang branch from fc2be03 to 971a42e Compare March 25, 2025 09:12
Copy link
Contributor

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can think of some improvements to add later, but this work gets us closer to our end goals.

@jvoravong jvoravong merged commit 03323c8 into signalfx:main Apr 1, 2025
82 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants