fix missing receiver_creator receiver

[omrozowicz-splunk]

Description: In #1944 useControlPlaneMetricsHistogramData was enabled by default, what made receiver_creator receiver disappear from the default metrics pipeline. This is the code that caused this:

    metrics:
      receivers:
        - hostmetrics
        - kubeletstats
        - otlp
        {{- if not .Values.featureGates.useControlPlaneMetricsHistogramData }}
        - receiver_creator
        {{- end }}

Currently, when autodetect.prometheus is set to true, receiver_creator receiver is created in the configuration and not included in the pipeline.

Testing: Manual testing

Documentation: N/A

[jinja2]

Good catch! But i think we have more configs to check for in this. There is also the autodetect.istio. And then there is the complex situation of both the autodect + controlPlaneHistograms being enabled which right now will add same receivers to both pipelines.

[omrozowicz-splunk]

Good catch! But i think we have more configs to check for in this. There is also the autodetect.istio. And then there is the complex situation of both the autodect + controlPlaneHistograms being enabled which right now will add same receivers to both pipelines.

Hey @jinja2, you're right! I added autodetect.istio to the condition.

complex situation of both the autodect + controlPlaneHistograms being enabled

can you explain what part exactly you mean? because the condition currently is:

{{- if or (not .Values.featureGates.useControlPlaneMetricsHistogramData) .Values.autodetect.prometheus .Values.autodetect.istio }}

so this will be rendered when useControlPlaneMetricsHistogramData is not enabled.