Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git remote parsing, allow for non git directories, updated linting, readme and hidden file_name #18

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

tofran
Copy link
Member

@tofran tofran commented Mar 14, 2024

  1. Closes GIT_REPOSITORY_REGEX should accept more repo url's  #16 - allow for more generic git url parsing.
  2. Allow using 1password-secrets outside git repos or git repos without a remote named "origin" - or even if git is not installed.
  3. Had to update the dev deps as I faced an odd bug in pycodestyle:
    pycodestyle .
    ./onepassword_secrets.py:412:51: E231 missing whitespace after ':'
    ./onepassword_secrets.py:429:51: E231 missing whitespace after ':'
    ./onepassword_secrets.py:456:52: E231 missing whitespace after ':'
    ./onepassword_secrets.py:478:52: E231 missing whitespace after ':'
    ./onepassword_secrets.py:494:57: E231 missing whitespace after ':'
    
  4. Updated readme
  5. Fixed note creation that would set file_name as a password and not as a text field (only has UI implications).

@tofran tofran self-assigned this Mar 14, 2024
@tofran tofran changed the title fix git remote regex and updated linting deps Fix git remote parsing, allow for non git directories, updated linting, readme and hidden file_name Mar 15, 2024
@tofran tofran merged commit a64e47e into main Mar 15, 2024
2 checks passed
@tofran tofran deleted the fix-git-remote-regex branch March 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

GIT_REPOSITORY_REGEX should accept more repo url's
2 participants