Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decided msg handling #139

Merged
merged 21 commits into from
Feb 19, 2025
Merged

Decided msg handling #139

merged 21 commits into from
Feb 19, 2025

Conversation

Zacholme7
Copy link
Member

Issue Addressed

Other part of #103

Proposed Changes

A pretty simple implementation. If we recieve a decided message, which is identified by having > 1 signature, we can immediately complete our instance. All verification is to be done upstream. The only remaining part of this is to validate the signatures in #137

@Zacholme7 Zacholme7 added the QBFT label Feb 14, 2025
@Zacholme7 Zacholme7 marked this pull request as ready for review February 14, 2025 22:17
anchor/common/qbft/src/lib.rs Outdated Show resolved Hide resolved
anchor/common/qbft/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@dknopik dknopik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Zacholme7 Zacholme7 requested a review from dknopik February 19, 2025 14:20
@Zacholme7 Zacholme7 merged commit 1648e15 into sigp:unstable Feb 19, 2025
10 checks passed
@Zacholme7 Zacholme7 deleted the decided-msg branch February 19, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants