Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mermaid support for our mdbook #55

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

AgeManning
Copy link
Member

Issue Addressed

Just browsing our book and noticed we don't have mermaid support.

This adds support for mermaid diagrams, however I've had to mess with the workflow and I've not tested the new build.

This works locally, but it remains to be seen if this holds up in the CI

Clone of #53

@AgeManning AgeManning added the ready-for-review This PR is ready to be reviewed label Nov 26, 2024
jking-aus
jking-aus previously approved these changes Nov 26, 2024
Copy link
Contributor

@jking-aus jking-aus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but confirm you want this merged to stable not unstable

@AgeManning AgeManning changed the base branch from stable to unstable November 26, 2024 04:50
@AgeManning AgeManning dismissed jking-aus’s stale review November 26, 2024 04:50

The base branch was changed.

@AgeManning
Copy link
Member Author

Nope, thanks for the catch.

Fixed

Copy link
Contributor

@jking-aus jking-aus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jking-aus jking-aus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jking-aus jking-aus merged commit c505900 into sigp:unstable Dec 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants