Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore HTTP API logging and add more metrics #7225

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Restore HTTP API logging and add more metrics #7225

wants to merge 1 commit into from

Conversation

macladson
Copy link
Member

Issue Addressed

#7124

Proposed Changes

  • Restores previous HTTP logging with tracing compatible syntax
  • Adds metrics for certain missing endpoints (and alphabetized the existing ones)

michaelsproul
michaelsproul approved these changes Mar 29, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a code PoV. I will test it once manually and then we can merge

@macladson
Copy link
Member Author

For the metrics, there might be some v2 and v3 endpoints I've missed. Since some of our endpoints are version agnostic now it's hard to tell at a glace which versions exist, but I'll cross check them with the spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
HTTP-API UX-and-logs work-in-progress PR is a work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macladson @michaelsproul