ci: Don't test the develop branch of qmk/qmk_firmware
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, the code from the `develop` branch can't be compiled using `gcc-arm-none-eabi-7-2018-q2-update`, which is the newest version of the ARM toolchain available in Guix at the moment. The problem is that the code from https://www.github.com/qmk/qmk_firmware/pull/21656 uses `_Alignas` in compound literals, which requires GCC >= 8.x. Disable tests for the `develop` branch in CI; this will keep it working until the next round of breaking changes merge in QMK, at which point the ARM support would need to be dropped until a more recent version of the ARM embedded toolchain appears in Guix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the code from the
developbranch can't be compiled usinggcc-arm-none-eabi-7-2018-q2-update, which is the newest version of the ARM toolchain available in Guix at the moment. The problem is that the code from https://www.github.com/qmk/qmk_firmware/pull/21656 uses_Alignasin compound literals, which requires GCC >= 8.x.Disable tests for the
developbranch in CI; this will keep it working until the next round of breaking changes merge in QMK, at which point the ARM support would need to be dropped until a more recent version of the ARM embedded toolchain appears in Guix.