Support optional cupy for faster BSS evaluation #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs float64 or it gets large errors in regression tests
sevagh
force-pushed
the
feat/cupy-accel
branch
from
aff41a9 to
d527421
Compare
|
In hindsight I'm kinda uncertain where the "disable_cupy", "clear_cupy_cache", etc. functions would go, or if they even belong in the package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up BSS metrics with the GPU and CUDA-Python (cupy).
Regression tests pass. Usability is possibly a concern, given that
clear_cupy_cache()should be run regularly between tracks to avoid GPU OOM errors when the FFT plan cache fills up for a single evaluated track.I can squash my git commits as required.