Skip to content

Commit

Permalink
Merge pull request #215 from hectorj2f/deprecate_secret-name_flag
Browse files Browse the repository at this point in the history
Start deprecation of --secret-name
  • Loading branch information
vaikas authored Sep 6, 2022
2 parents e060c60 + 50f707a commit 2bb3a06
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cmd/webhook/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ import (
cwebhook "github.com/sigstore/policy-controller/pkg/webhook"
)

var secretName = flag.String("secret-name", "", "The name of the secret in the webhook's namespace that holds the public key for verification.")
// Deprecated: this flag will be removed in the future
var secretName = flag.String("secret-name", "", "Flag -secret-name has been deprecated and will be removed in the future. The name of the secret in the webhook's namespace that holds the public key for verification.")

// webhookName holds the name of the validating and mutating webhook
// configuration resources dispatching admission requests to policy-controller.
Expand Down
1 change: 1 addition & 0 deletions config/webhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ spec:
# and substituted here.
image: ko://github.com/sigstore/policy-controller/cmd/webhook
args: [
# DEPRECATED: -secret-name will be removed in the future.
"-secret-name=verification-key",
# Uncomment these to initialize with a custom TUF root.
# TODO: How to specify the entire TUF directory for multiple
Expand Down

0 comments on commit 2bb3a06

Please sign in to comment.