Skip to content

Make attestation bucket optional#213

Merged
cmurphy merged 1 commit into
sigstore:mainfrom
cmurphy:attestation-optional
May 12, 2026
Merged

Make attestation bucket optional#213
cmurphy merged 1 commit into
sigstore:mainfrom
cmurphy:attestation-optional

Conversation

@cmurphy
Copy link
Copy Markdown
Contributor

@cmurphy cmurphy commented May 12, 2026

If Rekor v1 isn't deployed or if enable_attestations is false, the attestation bucket name does not need to be set.

Relates to https://github.com/sigstore/public-good-instance/issues/3603

Summary

Release Note

Documentation

@cmurphy cmurphy requested a review from a team as a code owner May 12, 2026 17:32
Copy link
Copy Markdown
Contributor

@Hayden-IO Hayden-IO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a check that attestation_bucket is not empty is enable_attestations is set? Around

resource "google_storage_bucket" "attestation" {

If Rekor v1 isn't deployed or if enable_attestations is false, the
attestation bucket name does not need to be set.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
@cmurphy cmurphy force-pushed the attestation-optional branch from e0db81c to df49b8b Compare May 12, 2026 21:04
@cmurphy cmurphy merged commit 18c9965 into sigstore:main May 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants