Skip to content

conditionally create the public http security group #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briskt merged 1 commit into from
Nov 21, 2025
Merged

conditionally create the public http security group #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions vpc.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ module "alb" {
vpc_id = module.vpc.id
security_groups = [
module.vpc.vpc_default_sg_id,
var.use_cloudflare_sg ? module.cloudflare-sg.id : aws_security_group.public_https.id
var.use_cloudflare_sg ? module.cloudflare-sg.id : one(aws_security_group.public_https[*].id)
]
subnets = module.vpc.public_subnet_ids
certificate_arn = data.aws_acm_certificate.default.arn
Expand All @@ -115,6 +115,8 @@ module "alb" {
* Create security group to allow public access to HTTPS. Used when var.use_cloudflare_sg is false.
*/
resource "aws_security_group" "public_https" {
count = var.use_cloudflare_sg ? 0 : 1

name = "public-https"
description = "Allow HTTPS traffic from public"
vpc_id = module.vpc.id
Expand All @@ -124,11 +126,13 @@ resource "aws_security_group" "public_https" {
}

resource "aws_security_group_rule" "public_https" {
count = var.use_cloudflare_sg ? 0 : 1

type = "ingress"
from_port = 443
to_port = 443
protocol = "tcp"
security_group_id = aws_security_group.public_https.id
security_group_id = one(aws_security_group.public_https[*].id)
cidr_blocks = ["0.0.0.0/0"]
ipv6_cidr_blocks = ["::/0"]
}
Expand Down