Improve performance of the WorkflowInstance visualization #1091
+32,743
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial work for product deletion prompt * Change Remove Products to Delete Product * Add extra warning for when product is published * Fix text wrapping of prompt for mobile
* Rename system to recurring * Move langtags to static and fetch in load * Readfile instead of fetch * Add job to refresh langtags * Fix typing on LanguageCodeTypeahead * Move langtags to subfolder, add function for DRY * Add refresh langtags job on startup * Fetch localeNames too * Fix bug from not spreading * Make logs prettier * Fix XML parsing * Add localized names to root +layout.server.ts * Rename en-us to en-US to follow ldml source * Add localized language display names to /projects/[id] * Remove extraneous console.log * Handle localized display names in LanguageCodeTypeahead * Add separate shouldUpdate check for localized language names * Only write what is needed for langtags * Fix typing issue from LangCodeTypeAhead type fix * Only write what is needed for localized lang names Also write in format that works well for creating a Map * Fix shouldUpdate check * Localize langnames and territory names * Fix selection highlight * Wrap selectedIndex properly * Display correct property (nameInLocale) in display * Fix authenticated layout to use correct locale source * fix remaining reference to old l10n * Move code from utils/locales to i18n * Move localization map to global state * Fix localization tag mapping The tags had underscores in the ldml data but hyphens in the langtags.json * Add correct flags and l10n to LanguageSelector * Rename variable in tz selector for clarity * Fix styling on LanguageCodeTypeahead and tz selector * Use fallback flag in language selector * Rename LanguageSelector to LocaleSelector * Write and use function to localize name for display
* Add i18n from TODOs
* Add missing i18n strings
I couldn't get the inlang cli working to search for missing translations, so I used this series of grep commands to find everything I could:
git grep -E ">[^<]+" \
| grep "\.svelte" \
| grep -v "/instructions/" \
| grep -Ev "\{m\.|--|[{;]|Record<|//|=>"
Explanation
1. search for non-'<' characters after '>' (most likely to be content in a html tag)
2. limit results to .svelte files
3. ignore instructions folder (we may translate these later)
4. Ignore messages, comments, content in braces, and other TS code that happens to match initial grep.
* Change some i18n to use variants
* Fix pluralized i18n for LanguageCodeTypeahead
* Fix enum iteration
* Fix ValidI13nKey import
* Fix missing i18n from rebase
I. .... should have been more careful... I mixed up which index of the roles array was the OrganizationId and which was the RoleId, the very same problem these functions were originally designed to solve. Anyways, they are correct now.
* Create PropertiesEditor component Wraps a textarea with some extra validation for the Properties JSON string * Add Publishing Propeties editor for products * Fix reactivity of textarea * Fix compute type selection * Fix textarea clearing bug It was a form reset.... * Fix properties editor UX - Only show errors when not focused on text area - Immediately update ok status * Reset Properties value on cancel * Prevent flow/proddef submission if properties not ok * Fix issue with resetting computeType
* Delete/Create UserTasks on Project Archive/Reactivate * Block state jump when archived * Hide waiting time when archived Do we want any other UI changes while a project is archived??? * Fix product list rounding when task collapsed * Show archival date in project list and project page * Block task creation in tasks job instead of jump * Show different waiting message while archived * Also bold activityName regularly * Fix i18n mistake * Fix ProductTransitions on archival
FyreByrd
force-pushed
the
perf/springy-maps
branch
from
58b2294 to
3ed6457
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* Add individual field errors in admin/settings route * Fix i18n for editing in admin settings * Remove unused code in /organizations * Sort data for MultiSelectBox on server * Add individual field errors in /users/invite * Add individual field errors in /projects/new * Slightly better errors for project import * Include zerodevx/svelte-toast * Add simpler toast cases from S1 * Fix toast stacking * Add comment noting remaining locations for toasts * Require WorkflowDefinition.Name * Remove unnecessary error returns Returning form.errors is redundant. Already handled by returning form * Use consistent validation for org settings * Add a few more shared schemas for consistency * Use semantic input types * Consistent form structure and style * Use textarea vs input consistently, apply height * Remove unnecessary id attribute from inputs * Remove unnecessary logs * Fix names on org infrastructure page * Require url/token to be provided when not using default build engine * Automatic updates of stores/prodDefs in org settings * Toasts in org settings * Correct toasts and submission behavior in /users * Add empty pages for redirects in /users * Add extra validation to GroupMems/UserRoles * Improve server-side performance for user profile settings * Improve project validation performance Prisma does not currently have an `exists` function. For performance reasons, `findFirst` is recommended over `count` for approximating `exists` * Prevent TypeaheadInput from submitting a form The only time submission is desired is when searching by language code in project directory. Submission is handled by the onLanguageCodeSelected event * Fix timezone selection * Change user profile form validation * Consistent casing of Url in form fields * Consistent return across toggle for org functions * Remove extraneous console logs * Consolidate shared valibot schemas * Fix error return type for addIssue * Add clarifying comment for UserRoles task enqueuing * Fix escaping for phone regex, allow country code
* Remove TODOs for email notifications #1100 * Remove TODOs for Author.CanUpdate #1101 * Remove TODOs for DB changes #1102 * Remove TODOs for workflow localization #1104 * Update documentation (and remove TODOs) for route handler * Remove TODO for workflow instance visualization #1105 * Remove extraneous TODOs * Remove TODOs for better server side errors #1116
* Add clear button to DateRangePicker * Actually use the i18n key that I created for this express purpose... * Fix es l10n for clear message * Fix date value resetting
* Use 6173 for UI and 6000 for jobs * Change 6000 to 6100 6000 is commonly used by X11
* Tweak threshold for LanguageCode fuzzy matching Tightening the threshold from 0.6 down to 0.2 seems to get more desirable results. * Shift longer values in UI to show highlighting Some of the searched values are long enough that some matches are not shown in the UI because of clamping. This fixes that by shifting what is shown such that the first match will be shown. * Various fixes
FyreByrd
force-pushed
the
feature/svelte
branch
from
ac04852 to
2167c53
Compare
FyreByrd
force-pushed
the
perf/springy-maps
branch
from
3ed6457 to
509b069
Compare
7dev7urandom
force-pushed
the
feature/svelte
branch
2 times, most recently
from
d944a45 to
bdbfe3f
Compare
|
Closing as stale (based on code from 6 months ago). If this is addressed again it will be from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few other bugs I've spotted when running this code after the upgrade to Svelte 5. I think it may be more an issue with Svelvet than this, but I should take a more thorough look. This may also be a good branch to keep open for looking at replacing this entirely...