-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add automatic build settings to Projects model. #1300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic build settings to Projects model. #1300
Conversation
WalkthroughAdds two boolean columns, Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could run npx prisma format
(shouldn't require a new migration) that would be great.
Otherwise looks good.
1a98769
to
e728598
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "AutomaticBuilds"
Update the prisma Projects model and generate migration for: - AutoPublishOnRebuild - RebuildOnSoftwareUpdate
e728598
to
0955bd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/lib/prisma/migrations/12_auto_rebuilds/migration.sql
(1 hunks)src/lib/prisma/schema.prisma
(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-16T13:58:15.749Z
Learnt from: FyreByrd
PR: sillsdev/appbuilder-portal#1286
File: src/routes/(authenticated)/admin/settings/organizations/new/+page.server.ts:15-15
Timestamp: 2025-09-16T13:58:15.749Z
Learning: In the appbuilder-portal codebase, multiple models have OwnerId fields (Groups, Projects, etc.) that are unrelated to each other. When removing Organizations.OwnerId, other models' OwnerId fields should not be affected as they serve different ownership relationships.
Applied to files:
src/lib/prisma/schema.prisma
📚 Learning: 2025-09-12T14:02:04.558Z
Learnt from: FyreByrd
PR: sillsdev/appbuilder-portal#1283
File: src/lib/server/workflow/index.ts:52-74
Timestamp: 2025-09-12T14:02:04.558Z
Learning: In the appbuilder-portal codebase, when a Product exists, it always has an associated Project relationship. The Project._count fields (Authors, Reviewers) are safe to access directly when the Product query returns a result.
Applied to files:
src/lib/prisma/schema.prisma
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: typecheck-lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Migration applies cleanly on existing local database without any issues.
Update the prisma Projects model and generate migration for:
Addresses #1236.
Summary by CodeRabbit