-
-
Notifications
You must be signed in to change notification settings - Fork 9
Upgrade packages #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade packages #1305
Conversation
Caution Review failedThe pull request is closed. WalkthroughBumps OpenTelemetry collector image tags to v0.136.0, updates multiple npm devDependencies and overrides, changes OrganizationDropdown props to accept Changes
Sequence Diagram(s)sequenceDiagram
participant Page as Page / Route
participant OrgDD as OrganizationDropdown
participant Router as SvelteKit goto
rect #EBF5FF
Note right of Page: New prop shape — pass select attributes/events via selectProperties
end
Page->>OrgDD: render(selectProperties = { onchange, name, ... })
OrgDD->>OrgDD: user changes selection (native select)
OrgDD->>Page: call selectProperties.onchange(event)
Page->>Router: goto(localizeUrl(...))
Router-->>Page: navigation complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/lib/components/OrganizationDropdown.svelte (1)
10-10
: Good refactor to explicit selectProperties API.The change from permissive rest props to an explicit
selectProperties
object improves API clarity and makes it obvious that these properties are forwarded to the underlying<select>
element. TheRecord<string, unknown>
type and default empty object are appropriate.Consider tightening the type to common HTML select attributes for better type safety:
selectProperties?: React.SelectHTMLAttributes<HTMLSelectElement> | Record<string, unknown>;However, since this is Svelte (not React), you might want to define a Svelte-specific type or use
svelte/elements
types if available, or keep the current flexible approach for custom attributes.Also applies to: 18-18, 22-22
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/lib/components/OrganizationDropdown.svelte
(1 hunks)src/routes/(authenticated)/organizations/[id=idNumber]/settings/+layout.svelte
(1 hunks)src/routes/(authenticated)/projects/[filter=projectSelector]/[orgId=idNumber]/+page.svelte
(1 hunks)src/routes/(authenticated)/users/invite/+page.svelte
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-22T14:59:53.366Z
Learnt from: FyreByrd
PR: sillsdev/appbuilder-portal#1297
File: src/routes/(authenticated)/projects/[filter=projectSelector]/[orgId=idNumber]/+page.server.ts:214-221
Timestamp: 2025-09-22T14:59:53.366Z
Learning: In the AppBuilder portal, bulk project actions in the route `/projects/[filter=projectSelector]/[orgId=idNumber]/+page.server.ts` are organization-scoped by design. The route parameter `[orgId=idNumber]` ensures all operations happen within a single organization context, so using the route-level orgId for all projects in bulk actions like `doProjectAction` is correct and safe.
Applied to files:
src/routes/(authenticated)/projects/[filter=projectSelector]/[orgId=idNumber]/+page.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-and-test
🔇 Additional comments (2)
src/routes/(authenticated)/projects/[filter=projectSelector]/[orgId=idNumber]/+page.svelte (1)
178-180
: LGTM! API migration to selectProperties.The OrganizationDropdown usage has been correctly updated to use the new
selectProperties
prop. Theonchange
handler (lowercase) is appropriate for the native<select>
element.src/routes/(authenticated)/users/invite/+page.svelte (1)
70-70
: LGTM! Correctly migrated to selectProperties.The
name
attribute has been correctly moved into theselectProperties
object, consistent with the new OrganizationDropdown API.
Upgrade and test all npm packages as well as docker image. Remove legacy express dependency.
All should be working as far as I can tell, some minor issues may surface as we use it.
Closes #1190, #1191, #1197, #1199, #1200, #1201, #1203, #1204, #1216, #1229, #1231, #1271, #1273
Summary by CodeRabbit
Chores
Bug Fixes / UI