-
-
Notifications
You must be signed in to change notification settings - Fork 26
Update GitVersion dependency to 6.3.0 #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Requires a couple changes to GitVersion.yml since GitVersion 6 renamed some of the properties we use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@rmunn The installer build is failing with a missing |
I see. They recommend replacing GitVersion_NuGetVersion (which would produce version strings like -beta0017) with GitVersion_SemVer, which produces version strings like -beta.17. We can reconstruct the old _NuGetVersion variable if we need to, by using Alternately, if we know we no longer need to support any versions of NuGet.exe older than 4.3.0 (which is QUITE old), then we can simply use If you think we need an exact equivalent to GitVersion_NuGetVersion then let me know, otherwise I'll update the build to use GitVersion_SemVer. |
Incidentally, this is the GitVersion commit that removed those variables. |
NuGetVersion variable produces suffixes like -beta0017, whereas SemVer variable produces suffixes like -beta.17 which comply with SemVer 2.0. SemVer 2.0 support was added in NuGet 4.3.0, which is quite ancient at this point, so we no longer need to use the NuGetVersion variable to support older tooling; all NuGet tools can handle SemVer 2.0 by now.
I have a concern about the version continuity and the version parsing strategies that are in use in existing projects. The build system we have in place would all need to be exercised out to the tip (installation) of each affected tool. FieldWorks, OneStoryEditor, LFMerge, ?? |
Good point Jason, I've been assuming that versioning systems would handle I'll back off the GitVersion update to the latest version of GitVersion 5.x, I believe it's 5.12.0, so that we can keep using NuGetVersion. Hopefully that will still fix #363 for me and allow me to build Chorus on Linux again. |
Fixes #363.
Requires a couple changes to GitVersion.yml since GitVersion 6 renamed some of the properties we use:
tag
becomeslabel
, andprevent-increment-of-merged-branch-version
has been split intoprevent-increment.of-merged-branch
(note the period). There's alsoprevent-increment.when-current-commit-tagged
which we aren't currently using.This change is