New Crowdin updates #2010
New Crowdin updates #2010
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughLocalized string updates in three PO files (es, id, ko): revised PO-Revision-Date headers and added translations for the string "Last sync: #". No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
the
💻 FW Lite
UI unit Tests 1 files 45 suites 28s ⏱️ Results for commit 22c7f86. ♻️ This comment has been updated with latest results. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎ Awaiting the start of a new Argos build… |
C# Unit Tests130 tests 130 ✅ 19s ⏱️ Results for commit 22c7f86. ♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
frontend/viewer/src/locales/es.po(2 hunks)frontend/viewer/src/locales/id.po(2 hunks)frontend/viewer/src/locales/ko.po(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: imnasnainaec
PR: sillsdev/languageforge-lexbox#1867
File: platform.bible-extension/src/main.ts:239-246
Timestamp: 2025-07-31T19:10:41.178Z
Learning: In the sillsdev/languageforge-lexbox repository, user imnasnainaec prefers to defer code improvements when there are related TODO comments indicating planned refactoring work, choosing to bundle related changes together rather than making incremental improvements that would need to be modified again during the larger refactoring.
📚 Learning: 2025-06-02T14:27:02.745Z
Learnt from: myieye
PR: sillsdev/languageforge-lexbox#1720
File: frontend/viewer/src/locales/es.json:1786-1790
Timestamp: 2025-06-02T14:27:02.745Z
Learning: Spanish locale file (frontend/viewer/src/locales/es.json) contains generated code that may have null line numbers in origin entries due to limitations in the code generation process.
Applied to files:
frontend/viewer/src/locales/es.po
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Build API / publish-api
- GitHub Check: Build UI / publish-ui
- GitHub Check: check-and-lint
- GitHub Check: Build FW Lite and run tests
- GitHub Check: frontend-component-unit-tests
- GitHub Check: frontend
🔇 Additional comments (5)
frontend/viewer/src/locales/es.po (1)
11-11: Header PO-Revision-Date updated — OK.frontend/viewer/src/locales/id.po (2)
11-11: Header PO-Revision-Date updated — OK.
602-603: Indonesian translation added for "Last sync: #" — LGTM.
Placeholder retained; matches style of "Perubahan terakhir: #".frontend/viewer/src/locales/ko.po (2)
11-11: Header PO-Revision-Date updated — OK.
602-603: Korean translation added for "Last sync: #" — LGTM.
Placeholder retained; consistent with "마지막 변경 사항: #".
| msgid "Last sync: #" | ||
| msgstr "" | ||
| msgstr "Última sincronización: #" |
There was a problem hiding this comment.
🧩 Analysis chain
Spanish translation added for "Last sync: #" — LGTM.
Placeholder preserved and style consistent with "Último cambio: #".
Run to confirm no locales still have an empty msgstr for this key:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
missing=$(rg -nUP 'msgid "Last sync: #"\s*\nmsgstr\s*""' frontend/viewer/src/locales -g '*.po' || true)
if [[ -n "$missing" ]]; then
echo "Missing translations:"
echo "$missing"
exit 1
else
echo "All locales have non-empty translations for 'Last sync: #'."
fiLength of output: 342
Spanish translation OK — missing translations for "Last sync: #".
- frontend/viewer/src/locales/sw.po:602-603 — msgstr ""
- frontend/viewer/src/locales/fr.po:602-603 — msgstr ""
- frontend/viewer/src/locales/ms.po:602-603 — msgstr ""
Add non-empty translations for "Last sync: #" in the above files, preserving the "#" placeholder.
🤖 Prompt for AI Agents
In frontend/viewer/src/locales/sw.po lines 602-603,
frontend/viewer/src/locales/fr.po lines 602-603, and
frontend/viewer/src/locales/ms.po lines 602-603 the msgstr for msgid "Last sync:
#" is empty; add a non-empty translated string in each file preserving the "#"
placeholder exactly (e.g., Swahili, French, Malay translations) so the
placeholder remains intact and the format stays msgid "Last sync: #" / msgstr
"your translation with #".
No description provided.