Skip to content

Conversation

siltomato
Copy link
Collaborator

@siltomato siltomato commented Sep 26, 2025

This PR fixes an issue where note embeds were causing lynx lib position calculations to be incorrect, as lynx lib uses the delta from the DB doc, not the editor delta which may contain note embeds.

The fix involves adjusting the offset used by lynx lib, subtracting the number of preceding note embeds.


This change is Reviewable

@siltomato siltomato added the will require testing PR should not be merged until testers confirm testing is complete label Sep 26, 2025
@siltomato siltomato marked this pull request as ready for review September 26, 2025 00:33
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 74.41860% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.18%. Comparing base (6c3aa27) to head (fa5607c).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ate/editor/lynx/insights/lynx-workspace.service.ts 75.00% 9 Missing and 1 partial ⚠️
...e/ClientApp/src/app/shared/text/text-view-model.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3470      +/-   ##
==========================================
- Coverage   82.18%   82.18%   -0.01%     
==========================================
  Files         611      611              
  Lines       36441    36459      +18     
  Branches     6005     6009       +4     
==========================================
+ Hits        29950    29964      +14     
- Misses       5610     5627      +17     
+ Partials      881      868      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman self-requested a review September 28, 2025 19:26
@pmachapman pmachapman self-assigned this Sep 28, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: I liked your updates to getOnTypeEdits, and how your solution separates concerns.

@pmachapman reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @siltomato)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants