Replace deprecated SubscriptionDisposable with DestroyRef and fix type safety issues #3514
+82
−80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR modernizes the frontend codebase by replacing deprecated Angular patterns with current recommended practices. The changes eliminate all deprecated API usage and improve type safety, ensuring compatibility with future Angular versions.
Changes Made
1. Migrated from SubscriptionDisposable to DestroyRef
Replaced the deprecated
SubscriptionDisposable
base class with Angular's modernDestroyRef
pattern in 5 components/services:Before:
After:
2. Fixed Deprecated fromEvent Type Parameters
Updated
sharedb-realtime-remote-store.ts
to use type assertions instead of deprecated explicit type parameters for RxJSfromEvent
:Before:
After:
3. Updated Tests
Updated all affected test files to properly mock
DestroyRef
:Impact
Why This Matters
The deprecated
SubscriptionDisposable
class was marked for removal as Angular now providesDestroyRef
as the official way to handle component cleanup. This migration:takeUntilDestroyed
operatorTesting
Verified functionality across multiple test suites:
All modified components have been thoroughly tested to ensure no regressions.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
accounts.google.com
/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4363 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-28811374 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,14683629626945241614,14049929453526293768,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)/usr/local/share/chromium/chrome-linux/chrome --user-data-dir=/tmp/karma-28811374 --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --no-sandbox --disable-extensions --use-fake-device-for-media-stream --use-fake-ui-for-media-stream --autoplay-policy=no-user-gesture-required --remote-debugging-port=9988 --headless --disable-gpu --disable-dev-shm-usage --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=28811374
(dns block)/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4505 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-67573815 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,15270322350340913338,14910253362746942240,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)android.clients.google.com
/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4363 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-28811374 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,14683629626945241614,14049929453526293768,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)/usr/local/share/chromium/chrome-linux/chrome --user-data-dir=/tmp/karma-28811374 --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --no-sandbox --disable-extensions --use-fake-device-for-media-stream --use-fake-ui-for-media-stream --autoplay-policy=no-user-gesture-required --remote-debugging-port=9988 --headless --disable-gpu --disable-dev-shm-usage --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=28811374
(dns block)/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4656 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-74372955 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,17194858283527730254,5181093158567068736,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)cdn.auth0.com
/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=5310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-63836314 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9285823493998262117,5832430567733367814,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)/usr/local/share/chromium/chrome-linux/chrome --user-data-dir=/tmp/karma-63836314 --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --no-sandbox --disable-extensions --use-fake-device-for-media-stream --use-fake-ui-for-media-stream --autoplay-policy=no-user-gesture-required --remote-debugging-port=9988 --headless --disable-gpu --disable-dev-shm-usage --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=63836314
(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js
(dns block)clients2.google.com
/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4363 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-28811374 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,14683629626945241614,14049929453526293768,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)/usr/local/share/chromium/chrome-linux/chrome --user-data-dir=/tmp/karma-28811374 --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --no-sandbox --disable-extensions --use-fake-device-for-media-stream --use-fake-ui-for-media-stream --autoplay-policy=no-user-gesture-required --remote-debugging-port=9988 --headless --disable-gpu --disable-dev-shm-usage --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=28811374
(dns block)/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4505 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-67573815 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,15270322350340913338,14910253362746942240,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)fonts.googleapis.com
ng build
(dns block)fonts.languagetechnology.org
/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=5310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-63836314 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9285823493998262117,5832430567733367814,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)/usr/local/share/chromium/chrome-linux/chrome --user-data-dir=/tmp/karma-63836314 --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --no-sandbox --disable-extensions --use-fake-device-for-media-stream --use-fake-ui-for-media-stream --autoplay-policy=no-user-gesture-required --remote-debugging-port=9988 --headless --disable-gpu --disable-dev-shm-usage --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=63836314
(dns block)redirector.gvt1.com
/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4363 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-28811374 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,14683629626945241614,14049929453526293768,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)/usr/local/share/chromium/chrome-linux/chrome --user-data-dir=/tmp/karma-28811374 --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --no-sandbox --disable-extensions --use-fake-device-for-media-stream --use-fake-ui-for-media-stream --autoplay-policy=no-user-gesture-required --remote-debugging-port=9988 --headless --disable-gpu --disable-dev-shm-usage --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=28811374
(dns block)/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4505 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-67573815 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,15270322350340913338,14910253362746942240,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)update.googleapis.com
/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=5310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-63836314 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9285823493998262117,5832430567733367814,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)/usr/local/share/chromium/chrome-linux/chrome --user-data-dir=/tmp/karma-63836314 --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --no-sandbox --disable-extensions --use-fake-device-for-media-stream --use-fake-ui-for-media-stream --autoplay-policy=no-user-gesture-required --remote-debugging-port=9988 --headless --disable-gpu --disable-dev-shm-usage --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=63836314
(dns block)www.google-analytics.com
ng lint
(dns block)ng test --browsers xForgeChromiumHeadless --source-map --watch=false --include **/pwa.service.spec.ts
(dns block)ng test --browsers xForgeChromiumHeadless --source-map --watch=false --include **/audio-player-base.component.spec.ts --include **/audio-player.component.spec.ts
(dns block)www.google.com
/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4363 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-28811374 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,14683629626945241614,14049929453526293768,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)/usr/local/share/chromium/chrome-linux/chrome --user-data-dir=/tmp/karma-28811374 --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --no-sandbox --disable-extensions --use-fake-device-for-media-stream --use-fake-ui-for-media-stream --autoplay-policy=no-user-gesture-required --remote-debugging-port=9988 --headless --disable-gpu --disable-dev-shm-usage --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl http://localhost:9876/?id=28811374
(dns block)/usr/local/share/chromium/chrome-linux/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-fake-device-for-media-stream --use-angle=swiftshader-webgl --crashpad-handler-pid=4505 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-67573815 --subproc-heap-profiling --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,15270322350340913338,14910253362746942240,262144 --disable-features=PaintHolding --variations-seed-version
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
This change is