Skip to content

Conversation

@marksvc
Copy link
Collaborator

@marksvc marksvc commented Oct 17, 2025

This change is Reviewable

@marksvc
Copy link
Collaborator Author

marksvc commented Oct 17, 2025

Oops. We weren't formatting .mts or .mjs files with the same rules. This addresses that.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.42%. Comparing base (733461b) to head (4f71a4a).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3523   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         615      615           
  Lines       36948    36948           
  Branches     6021     6045   +24     
=======================================
  Hits        30453    30453           
+ Misses       5610     5597   -13     
- Partials      885      898   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksvc marksvc marked this pull request as ready for review October 20, 2025 14:36
@pmachapman pmachapman removed the e2e Run e2e tests for this pull request label Oct 22, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @marksvc)

@pmachapman pmachapman merged commit cab9339 into master Oct 22, 2025
23 checks passed
@pmachapman pmachapman deleted the task/mts branch October 22, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants