Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Oct 22, 2025

This is a pre-requisite for #3508 to allow older clients running this logic to still view draft sources when Sf-3163 is deployed.


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.47%. Comparing base (93615cb) to head (2c11d2b).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/translate/draft-generation/draft-utils.ts 0.00% 5 Missing and 1 partial ⚠️
...c/SIL.XForge.Scripture/ClientApp/src/type-utils.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3531      +/-   ##
==========================================
- Coverage   82.48%   82.47%   -0.02%     
==========================================
  Files         615      615              
  Lines       36914    36921       +7     
  Branches     6009     6012       +3     
==========================================
  Hits        30450    30450              
- Misses       5579     5584       +5     
- Partials      885      887       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman added e2e Run e2e tests for this pull request and removed e2e Run e2e tests for this pull request labels Oct 22, 2025
Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@Nateowami Nateowami merged commit 84d060e into master Oct 22, 2025
35 of 38 checks passed
@Nateowami Nateowami deleted the feature/SF-3163a branch October 22, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants