Skip to content

Conversation

@siltomato
Copy link
Collaborator

@siltomato siltomato commented Nov 11, 2025

This PR upgrades the app to Angular 20. Used https://angular.dev/update-guide followed by manual fixes for tests.


This change is Reviewable

@siltomato siltomato added testing not required e2e Run e2e tests for this pull request labels Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.90%. Comparing base (648dfa2) to head (3a0e0ad).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
....Scripture/ClientApp/src/app/shared/verse-utils.ts 81.48% 3 Missing and 2 partials ⚠️
...checking-questions/checking-questions.component.ts 50.00% 1 Missing ⚠️
...ure/ClientApp/src/app/project/project.component.ts 0.00% 0 Missing and 1 partial ⚠️
...ditor/lynx/insights/lynx-editor-adapter-factory.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3568      +/-   ##
==========================================
- Coverage   82.91%   82.90%   -0.01%     
==========================================
  Files         605      607       +2     
  Lines       36988    36996       +8     
  Branches     6056     6065       +9     
==========================================
+ Hits        30667    30671       +4     
- Misses       5395     5410      +15     
+ Partials      926      915      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siltomato siltomato marked this pull request as ready for review November 14, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants