Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Deprecate passing null paramters for Form and ValidationResult methods #11564

Merged
merged 1 commit into from
Jan 29, 2025
Merged

API Deprecate passing null paramters for Form and ValidationResult methods #11564

merged 1 commit into from
Jan 29, 2025

Conversation

emteknetnz
Copy link
Member

Issue #11423

@emteknetnz emteknetnz mentioned this pull request Jan 17, 2025
Open
3 tasks
@emteknetnz emteknetnz marked this pull request as ready for review January 17, 2025 04:43
@emteknetnz emteknetnz force-pushed the pulls/5/depr-form-valid branch from c4c18c5 to 3ac5450 Compare January 28, 2025 00:53
GuySartorelli
GuySartorelli requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to set the scope for the deprecation notices to Deprecation::SCOPE_GLOBAL - leaving it as the default of SCOPE_METHOD will add a note to the deprecation notice along the lines of "The Form::sessionMessage() method is deprecated" which is not true.

@emteknetnz emteknetnz force-pushed the pulls/5/depr-form-valid branch from 3ac5450 to 50c5805 Compare January 29, 2025 21:14
@emteknetnz
Copy link
Member Author

Updated

GuySartorelli
GuySartorelli requested changes Jan 29, 2025
View reviewed changes
src/ORM/ValidationResult.php Outdated Show resolved Hide resolved
src/ORM/ValidationResult.php Outdated Show resolved Hide resolved
src/ORM/ValidationResult.php Outdated Show resolved Hide resolved
src/ORM/ValidationResult.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/depr-form-valid branch from 50c5805 to 70ed656 Compare January 29, 2025 21:56
GuySartorelli
GuySartorelli approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit e7cccf6 into silverstripe:5 Jan 29, 2025
17 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/depr-form-valid branch January 29, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli