Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting from assets does not work. #194

Open
martinviolet88 opened this issue Feb 10, 2020 · 9 comments
Open

Selecting from assets does not work. #194

martinviolet88 opened this issue Feb 10, 2020 · 9 comments
Labels

Comments

@martinviolet88
Copy link

Selecting images from the image libary does not work. After selecting they do appear under the bulk uploader but not in the grifield. After doing a hard ctrl shift r it does seem to work. So my guess it's a caching error? No error's found.

screencapture-localhost-theaterv2-admin-Artiesten-Producent-ArtiestPage-EditForm-field-ArtiestPage-item-35157-edit-2020-02-10-18_10_11 (1)

@guyvanbael
Copy link

any update on this?

@martinviolet88
Copy link
Author

@guyvanbael Nope, having the same problem?

@kinglozzer
Copy link
Member

I think this PR might also fix this issue: #205. Or possibly #206

@guyvanbael
Copy link

@kinglozzer just used dev-master in my latest project, but issue still occuring

@EdvJa
Copy link

EdvJa commented Dec 2, 2020

same issue here, after some time investigating the problem I didn't manage to find error or something... ended up here :)

@acndr
Copy link

acndr commented Sep 29, 2021

Did this ever get resolved? We've just discovered the same problem, also using dev-master.
However for us it seems to only be a problem about 50% of the time.

@acndr
Copy link

acndr commented Oct 3, 2021

After some digging I think I've found the problem to this. In the uploader.js file the bulkUploadFieldReducer reducer is wrapped with a JS DOMContentLoaded. However this file is only requested when a SiteTree page is loaded up in the CMS, meaning the DOM is already loaded and this reducer never gets added. This is only a problem when you load the CMS via /admin then browse to a page to edit - if you refresh on a SiteTree page or route straight to a page (e.g. /admin/pages/edit/show/1) then the correct events are fired and everything works.

I don't know enough about the admin javascript lifecycle to confidently create a PR for this, but perhaps someone else can use this info for a fix?

@kinglozzer

@martinviolet88
Copy link
Author

Would be awesome if we can get it fixxed;), i'm so annoyed by it that im willing to pay for someone to fix it haha..

@mikey-harveycameron
Copy link

mikey-harveycameron commented Sep 8, 2023

need this fixed... but not the jansneeuw namespace changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
8 participants