Fix for issue #194 #229
Closed
Fix for issue #194 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s added whenever the cms is loaded.
|
The namespace changes here make this PR completely unviable. I'm going to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194
The issue was caused by the fact that the needed javascript was only loaded when the uploadfields were present. Because the reducer was only injected when the DOM was loaded, however the DOMContentLoaded event will only be called on the initial load of the CMS. This means that the reducer would never get injected if you load a page without the uploadfields, and thus the needed functionalities would not be present.
To solve this issue I have loaded the javascript using a config into the main component of the CMS (LeftAndMain), meaning the reducer will always be injected (no matter what page you initially load into).