Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing import #276

Closed
wants to merge 9 commits into from
Closed

fix missing import #276

wants to merge 9 commits into from

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Apr 26, 2024

this make @var GridField works properly for static analysis

Description

phpstan complains about invalid gridfield

Manual testing steps

use phpstan and see
Parameter #2 $gridfield of class Colymba\BulkTools\HTTPBulkToolsResponse constructor expects SilverStripe\Forms\GridField\GridField, Colymba\BulkManager\BulkAction\GridField given.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli GuySartorelli changed the base branch from master to 4.0 April 28, 2024 21:23
@GuySartorelli GuySartorelli changed the base branch from 4.0 to master April 28, 2024 21:23
@GuySartorelli
Copy link
Member

Can you please target the 4.0 or 4 branch? Either one is fine.

@lekoala lekoala changed the base branch from master to 4 April 29, 2024 07:31
@lekoala lekoala changed the base branch from 4 to 4.0 April 29, 2024 07:31
@lekoala lekoala changed the base branch from 4.0 to master April 29, 2024 07:31
this make @var GridField works properly for static analysis

(cherry picked from commit 0d99be8)
@lekoala lekoala changed the base branch from master to 4.0 April 29, 2024 07:37
@lekoala lekoala mentioned this pull request Apr 29, 2024
@lekoala
Copy link
Contributor Author

lekoala commented Apr 29, 2024

@GuySartorelli i created another PR it was a nightmare to try to change this

@GuySartorelli
Copy link
Member

Closing in favor of #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants