Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Commit

Permalink
Removed a console.warn that could make things explode if firefox does…
Browse files Browse the repository at this point in the history
…n't have firebug installed
  • Loading branch information
Silvestre Herrera committed May 7, 2016
1 parent 12643fa commit 1db21a5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
5 changes: 0 additions & 5 deletions lib/methods/on.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ function on(event, selector, callback) {
this.trackedElements[selector].nodes.push(item);
}

if (typeof this.trackedElements[selector][event] === 'function' &&
typeof callback === 'function') {
console.warn(`${selector}'s ${event} callback was overridden`);
}

if (typeof callback === 'function') {
this.trackedElements[selector][event] = callback;
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "onscreen",
"version": "1.1.1",
"description": "A light UI library that does stuff when the matched elements enter or leave the viewport",
"description": "A light library that does stuff when the matched elements enter or leave the viewport",
"main": "dist/onScreen.umd.js",
"jsnext:main": "dist/onScreen.es6.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion test/insideViewport_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function takeScreenshot() {
if (window.callPhantom) {
const date = new Date();
const filename = `screenshots/${date.getTime()}`;
console.log(`Taking screenshot ${filename}`);

callPhantom({
screenshot: filename
});
Expand Down

0 comments on commit 1db21a5

Please sign in to comment.