Replace auto-scale toggle with domain widget on line vis #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
force-pushed
the
custom-line-domain
branch
from
8d09c1e
to
4eabd44
Compare
|
/approve |
axelboc
force-pushed
the
custom-line-domain
branch
from
4eabd44
to
0f2a495
Compare
|
/approve |
axelboc
force-pushed
the
custom-line-domain
branch
from
89711fc
to
13b6683
Compare
axelboc
commented
Jun 10, 2024
axelboc
force-pushed
the
custom-line-domain
branch
from
13b6683
to
4cc58e4
Compare
axelboc
commented
Jun 13, 2024
loichuder
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1572, I replace the Autoscale toggle with a custom domain widget on the line (and complex line) visualization.
By removing the Autoscale toggle, we loose the ability to find the domain of the entire dataset and to set it automatically as the domain of the visualization.
However, the toggle also came with the side effect of triggering a fetch of the entire dataset, which could have very bad consequences with very large datasets (e.g. unresponsive server or browser), so I think removing it is a good thing. I also like the fact that the behaviour (and code) is now consistent between the line and heatmap visualizations.